Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support cohort targeting for local evaluation #47

Merged
merged 44 commits into from
Aug 27, 2024
Merged

feat: support cohort targeting for local evaluation #47

merged 44 commits into from
Aug 27, 2024

Conversation

tyiuhc
Copy link
Collaborator

@tyiuhc tyiuhc commented Jun 14, 2024

Summary

Support cohort targeting for local evaluation

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

@tyiuhc tyiuhc marked this pull request as ready for review June 14, 2024 22:29
@tyiuhc tyiuhc requested a review from bgiori June 14, 2024 22:29
bgiori
bgiori reviewed Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@bgiori bgiori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice. Couple of simplifications suggested.

Lets talk through config's api key, deployment key, etc. tomorrow.

src/amplitude_experiment/cohort/cohort_download_api.py Outdated Show resolved Hide resolved
src/amplitude_experiment/deployment/deployment_runner.py Outdated Show resolved Hide resolved
src/amplitude_experiment/deployment/deployment_runner.py Outdated Show resolved Hide resolved
src/amplitude_experiment/deployment/deployment_runner.py Outdated Show resolved Hide resolved
@tyiuhc tyiuhc requested a review from bgiori June 26, 2024 21:08
@tyiuhc
do not throw exception upon start() if cohort download fails, log war…
c71e0c7 
…ning if evaluating flag without required cohorts
@tyiuhc
update cohort_sync_config fields: include polling and remove request …
06e693e 
…delay, use enum for serverzone, update tests accordingly
@tyiuhc tyiuhc requested a review from bgiori August 7, 2024 20:18
@tyiuhc tyiuhc merged commit d8c62c4 into main Aug 27, 2024
3 checks passed
@tyiuhc tyiuhc deleted the local-cohort branch August 27, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgiori bgiori bgiori approved these changes

@zhukaihan zhukaihan Awaiting requested review from zhukaihan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tyiuhc @bgiori @zhukaihan